Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WS-470] Fix/submit buttons #135

Merged
merged 5 commits into from
Mar 21, 2024
Merged

[WS-470] Fix/submit buttons #135

merged 5 commits into from
Mar 21, 2024

Conversation

TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Mar 21, 2024 •
edited by jira bot
Loading

Minor Submit Button Fixes

JIRA

WS-470

Description

  • Small fixes to submit_buttons in the toolbox.
    • Added optional set_saved argument for each submit_button to allow for the page to unload without warning if the button is clicked.
    • Changed default button css to better center the text.

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

No. Optional set_saved arg is availible for each submit_button.

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label Mar 21, 2024
@TrevorBurgoyne TrevorBurgoyne changed the title Fix/submit buttons [WS-470] Fix/submit buttons Mar 21, 2024
@TrevorBurgoyne TrevorBurgoyne merged commit 76157eb into main Mar 21, 2024
@TrevorBurgoyne TrevorBurgoyne deleted the fix/submit-buttons branch March 21, 2024 17:56
@TrevorBurgoyne TrevorBurgoyne mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TrevorBurgoyne